Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Hide Content Editor workspace view when no properties (Document, Media, Member) #2075

Merged

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jul 2, 2024

Description

Review #2061 first as these changes are included in this PR.

This PR adds a condition to check for properties on a content item. The condition will only be permitted if it finds any properties.

Content with properties

When a content item has properties everything should work as before.

Screenshot 2024-07-02 at 08 04 56

Content with no properties

When a content item doesn't have any properties the "Content" workspace view is hidden

Screenshot 2024-07-02 at 08 04 46

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen marked this pull request as ready for review July 2, 2024 07:16
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a code perspective, but have not tested it jet.

@iOvergaard iOvergaard merged commit de91505 into main Jul 5, 2024
7 checks passed
@iOvergaard iOvergaard deleted the v14/bugfix/hide-content-workspace-view-when-no-properties branch July 5, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants