-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Hide Content Editor workspace view when no properties (Document, Media, Member) #2075
Merged
iOvergaard
merged 17 commits into
main
from
v14/bugfix/hide-content-workspace-view-when-no-properties
Jul 5, 2024
Merged
Bugfix: Hide Content Editor workspace view when no properties (Document, Media, Member) #2075
iOvergaard
merged 17 commits into
main
from
v14/bugfix/hide-content-workspace-view-when-no-properties
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkspace-view-when-no-properties
7 tasks
nielslyngsoe
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a code perspective, but have not tested it jet.
iOvergaard
approved these changes
Jul 5, 2024
iOvergaard
deleted the
v14/bugfix/hide-content-workspace-view-when-no-properties
branch
July 5, 2024 09:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review #2061 first as these changes are included in this PR.
This PR adds a condition to check for properties on a content item. The condition will only be permitted if it finds any properties.
Content with properties
When a content item has properties everything should work as before.
Content with no properties
When a content item doesn't have any properties the "Content" workspace view is hidden
Types of changes