Bugfix: Show correct msg for ApiError #2078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
requested changes
Jul 3, 2024
There was a problem hiding this comment.
Nice to see the errors starting to be shown. I added some suggestions down here. I think we should consider how to translate these messages as they are only fallback texts from the server. Do you know if they forward some sort of error code, we could hook in to?
iOvergaard
reviewed
Jul 4, 2024
…://github.com/umbraco/Umbraco.CMS.Backoffice into v14/bugfix/show-correct-api-error-description
iOvergaard
reviewed
Jul 4, 2024
src/packages/core/notification/layouts/default/notification-layout-default.element.ts
Outdated
Show resolved
Hide resolved
iOvergaard
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shows a more detailed ApiError description
Are there any place I have missed?
Types of changes
How to test?