Bugfix: Correct static file values #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/packages/core/workspace/components/workspace-split-view/workspace-split-view.element.ts
# Conflicts: # src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts # Conflicts: # src/packages/block/block-grid/components/block-grid-areas-container/block-grid-areas-container.element.ts # src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts
iOvergaard
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Living with the current situations of file pickers returning their unique, aka. a URL encoded Path. Meaning we had to handle decoding it. This should be changed in v.15 and there is created a PBI for that.
This makes, layout stylesheet and thumbnail file pickers work for Block Editors.
If anyone have saved a static file in Block Editor, they now have a invalid value. But as these features never was implemented is hard to determin, but thats why i put breaking on this PR.
Fixes umbraco/Umbraco-CMS#16738
Fixes umbraco/Umbraco-CMS#16598
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist