-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Property Type workspace #2095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/packages/core/property-type/workspace/views/settings/property-workspace-view-settings.element.ts
iOvergaard
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Property Type modal a proper Workspace, as we have done with other editor modals. This is one of the first modals and did therefor not follow the common approach.
There is many good reasons to align this:
First and foremost this fixes an issue that has occurred on the Main branch with the old-wanna-be-workspace solution. There workspace views conditions got confused. Instead of fixing that specific issue I decided to get Property Type up to speed with everything else.
As the property type modal is a proper workspace, it means it now is compatible with Property Editors, making us able to switch out the hardcoded UI with generic Property Editor UIs(this is not part of this PR, except its now posible)
Even more interesting it means that extensions can bring their own workspace views or workspace actions for the Property Type Workspace.
In the name of the future the Workspace is then ready for proper validation implementation potentially with server validation etc.
Breaking in the case that this PR removes property-type-settings-modal, as that is not implemented as a workspace. — but I would not assume any one would be implementing that in their code.
Description
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist