Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Property Type workspace #2095

Merged
merged 17 commits into from
Jul 5, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jul 4, 2024

Makes the Property Type modal a proper Workspace, as we have done with other editor modals. This is one of the first modals and did therefor not follow the common approach.

There is many good reasons to align this:

First and foremost this fixes an issue that has occurred on the Main branch with the old-wanna-be-workspace solution. There workspace views conditions got confused. Instead of fixing that specific issue I decided to get Property Type up to speed with everything else.

As the property type modal is a proper workspace, it means it now is compatible with Property Editors, making us able to switch out the hardcoded UI with generic Property Editor UIs(this is not part of this PR, except its now posible)

Even more interesting it means that extensions can bring their own workspace views or workspace actions for the Property Type Workspace.

In the name of the future the Workspace is then ready for proper validation implementation potentially with server validation etc.

Breaking in the case that this PR removes property-type-settings-modal, as that is not implemented as a workspace. — but I would not assume any one would be implementing that in their code.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe merged commit 59118e5 into main Jul 5, 2024
7 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/property-type-workspace branch July 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants