Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added Umb-Notifications #2098

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jul 5, 2024

Description

Added UmbNotifications!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

How to test?

    public void Handle(TemplateSavingNotification notification)
    {
        notification.Messages.Add(new EventMessage("Just some info", "Custom message", EventMessageType.Info));
        notification.Messages.Add(new EventMessage("Just an error", "Sending a notification with the error look", EventMessageType.Error));
        notification.Messages.Add(new EventMessage("Just a warning", "Another custom message", EventMessageType.Warning));
        notification.Messages.Add(new EventMessage("Just a default", "My default message", EventMessageType.Default));
        notification.Messages.Add(new EventMessage("Just a success", "Best color", EventMessageType.Success));

        notification.CancelOperation(
        new EventMessage(
            "Error",
            "This is my custom message: Operation not allowed.",
            EventMessageType.Error));

    }

Screenshots (if appropriate)

image

@loivsen loivsen marked this pull request as ready for review July 5, 2024 09:27
@loivsen loivsen requested a review from iOvergaard July 5, 2024 09:51
@loivsen loivsen marked this pull request as draft July 5, 2024 12:09
@loivsen loivsen marked this pull request as ready for review July 8, 2024 08:22
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iOvergaard iOvergaard enabled auto-merge July 8, 2024 08:31
@iOvergaard iOvergaard merged commit daf177b into main Jul 8, 2024
7 checks passed
@iOvergaard iOvergaard deleted the v14/feature/added-umb-notifications branch July 8, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants