hotfix: block grid live editing race condition #2101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Block Grid Editor only set its data if its not in Live Editing Mode. Cause otherwise they end up competing with each other and eventually out rule the corrections made by the Property Editor.
Fixes: umbraco/Umbraco-CMS#16227
Here a semantic diff for better overview:
https://app.semanticdiff.com/gh/umbraco/Umbraco.CMS.Backoffice/pull/2101/changes#src/packages/block/block/workspace/block-workspace.context.ts
Types of changes
This makes sure the Block Workspace observes data of the Property Editor while in create-state, in this way the corrections made of the Property Editor, like rowSpan setting, gets set and the Block Workspace receives that correction.
Only sets the Blocks data if its not in live editing mode. Cause setting these will eventually overwrite the corrections from the Property Editor.
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist