Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14: The option usernameIsEmail is not supported #2105

Merged
merged 10 commits into from
Jul 9, 2024

Conversation

iOvergaard
Copy link
Collaborator

@iOvergaard iOvergaard commented Jul 8, 2024

Description

This fixes a few things seeing that before, the option usernameIsEmail was not supported -- at least not set to false.

This adds a "username" field to the user profile settings as well as a repository/store combo to fetch the user configuration settings, which have now been added to the backend (new API models are included).

Fixes umbraco/Umbraco-CMS#16512

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Motivation and context

Ideally, we'd like to have some kind of model state on the user details model, but for now, we can get the information through the user configuration endpoint. The only scenario we cannot solve in the UI at the moment is a more complex one where a login provider is set to "deny local login". In that case, the server will refuse any username changes.

How to test?

  1. First spin up the backoffice and check that only the email field is shown and that you can change it (it should update both the email and userName properties).
  2. Next, go to appsettings and set Umbraco:CMS:Security:usernameIsEmail to false
  3. Go back to the backoffice and check that you'll now see both a "username" and an "email" property on the user details, and that you can change each independently on the other

Screenshots (if appropriate)

image

@iOvergaard
Copy link
Collaborator Author

Uh, I need to use your feature from #2106 as well, @leekelleher !

@leekelleher leekelleher merged commit 7ce4168 into main Jul 9, 2024
7 checks passed
@leekelleher leekelleher deleted the v14/bugfix/username-is-email branch July 9, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V14] Can't update the email of a user
2 participants