Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Use the EyeDropper Color Picker for choosing colors in blocks #2112

Merged
merged 14 commits into from
Jul 18, 2024
Merged

Bugfix: Use the EyeDropper Color Picker for choosing colors in blocks #2112

merged 14 commits into from
Jul 18, 2024

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Jul 11, 2024 •
edited
Loading

Description

Color picker for picking colors in blocks, rather than typing them manually 🥰

  • Added some localizations
  • Fixed a bug in blocks where the color picked for icons would not show

Fixes umbraco/Umbraco-CMS#16737

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@loivsen loivsen marked this pull request as ready for review July 16, 2024 09:08
@loivsen loivsen requested review from iOvergaard and leekelleher and removed request for iOvergaard July 16, 2024 09:29
iOvergaard
iOvergaard requested changes Jul 16, 2024
View reviewed changes
src/packages/core/components/icon/icon.element.ts Outdated Show resolved Hide resolved
src/packages/core/components/icon/icon.element.ts Outdated Show resolved Hide resolved
src/packages/core/components/icon/icon.element.ts Outdated Show resolved Hide resolved
src/packages/core/components/icon/icon.element.ts Outdated Show resolved Hide resolved
iOvergaard
iOvergaard reviewed Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great, just one last comment on the undefined vs 'inherit' when there is no color.

@loivsen @iOvergaard
Update src/packages/core/components/icon/icon.element.ts
f10d622 
Co-authored-by: Jacob Overgaard <752371+iOvergaard@users.noreply.github.com>
@loivsen loivsen requested a review from iOvergaard July 18, 2024 09:37
@iOvergaard iOvergaard merged commit 777c693 into main Jul 18, 2024
7 checks passed
@iOvergaard iOvergaard deleted the v14/bugfix/use-eyedropper-for-blocks branch July 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

@leekelleher leekelleher Awaiting requested review from leekelleher

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V14 Block Data Types are missing color pickers for background color and icon color
2 participants
@loivsen @iOvergaard