Bugfix: Date Picker with only "date" or "time" does not display correctly #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… send various datetime strings regardless of the configuration of the property editor, for example the "time" configuration could still be complete datetime string
… the format is 100% matching
… because the server always expects datetimes whereas the client expects differentiated strings
iOvergaard
changed the title
leekelleher
approved these changes
Jul 15, 2024
iOvergaard
added a commit
that referenced
this pull request
Jul 16, 2024
* fix: takes care of a case where the server and/or input element could send various datetime strings regardless of the configuration of the property editor, for example the "time" configuration could still be complete datetime string * test: adds tests for all the various input and output cases to ensure the format is 100% matching * fix: add `_inputValue` to differ between the input and output values, because the server always expects datetimes whereas the client expects differentiated strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The server always expects a regular DateTime string because the property value converter does not consider the config. The value will be unset if the string does not validate as a DateTime.
This PR aims to differentiate between input and output dates to communicate the expected value to the underlying date input component. The UI component expects the following:
Because of this, we have to patch the value coming out of the UI into a regular DateTime. Vice-versa we have to patch the value from the database into the expected inner input value.
Fixes umbraco/Umbraco-CMS#16779
How to test
HH:mm:ssScreenshots