Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Show the action button inside a button-group only if there are extensions registered #2137

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

iOvergaard
Copy link
Collaborator

Description

By moving the calculation of the extension controllers from the action-menu element into the action element itself, we can save a few states, simplify the calculation, and conditionally render the action-menu element ensuring, that the UUI styling is correctly applied

Fixes umbraco/Umbraco-CMS#16362

…xtensions registered

by moving the calculation of the extension controllers from the action-menu element into the action element itself, we can save a few states, simplify the calculation, and conditionally render the action-menu element ensuring, that the UUI styling is correctly applied
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-2137.westeurope.1.azurestaticapps.net

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, LGTM! 🚀

@iOvergaard iOvergaard merged commit 109cf92 into main Jul 24, 2024
8 checks passed
@iOvergaard iOvergaard deleted the v14/bugfix/workspace-action-menu-border-radius branch July 24, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save button has border radius on one side
2 participants