Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bundle tiny-mce package #2141

Merged
merged 12 commits into from
Aug 5, 2024
Merged

Chore: Bundle tiny-mce package #2141

merged 12 commits into from
Aug 5, 2024

Conversation

iOvergaard
Copy link
Collaborator

Description

See #1977 for more details about the bundling changes.

This PR bundles the Tiny-mce Package including all modules.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, the assets get minified, but I get an error when loading up the RTE in the backoffice. Associated CSS files aren't being loaded in...

Screenshot 2024-07-25 165650

I didn't get that error previously.

@iOvergaard
Copy link
Collaborator Author

Thanks, @leekelleher. Looks like the order of imports gets mixed up. Will take a look soon.

@iOvergaard
Copy link
Collaborator Author

@leekelleher I have fixed another issue for TinyMCE where the language in the iframe wasn't set correctly, however, I have been unable to reproduce your findings here.

I have deleted the StaticAssets/wwwroot/umbraco/backoffice folder entirely and rebuilt the branch and the rich text editor worked. Could you try again after the latest merge of the main branch, maybe that solved it?

@leekelleher
Copy link
Member

I've re-tested this on the latest branch, but I'm still getting the same errors (with the CSS 404s and importmap).
@madsrasmussen would you be able to review this at some point? (more as a sanity check).

Copy link

sonarcloud bot commented Aug 5, 2024

@madsrasmussen madsrasmussen self-assigned this Aug 5, 2024
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested with @madsrasmussen, turns out that the issues I was experiencing was specific with TinyMCE's Inline mode, (which currently has its own issues, see umbraco/Umbraco-CMS#16517).

Aside from that, the bundling LGTM! 👍

@iOvergaard iOvergaard merged commit d8b72cf into main Aug 5, 2024
8 checks passed
@iOvergaard iOvergaard deleted the v14/chore/bundle-tiny-mce branch August 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants