-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Bundle tiny-mce package #2141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @leekelleher. Looks like the order of imports gets mixed up. Will take a look soon. |
@leekelleher I have fixed another issue for TinyMCE where the language in the iframe wasn't set correctly, however, I have been unable to reproduce your findings here. I have deleted the |
I've re-tested this on the latest branch, but I'm still getting the same errors (with the CSS 404s and importmap). |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested with @madsrasmussen, turns out that the issues I was experiencing was specific with TinyMCE's Inline mode, (which currently has its own issues, see umbraco/Umbraco-CMS#16517).
Aside from that, the bundling LGTM! 👍
Description
See #1977 for more details about the bundling changes.
This PR bundles the Tiny-mce Package including all modules.
Types of changes