Bugfix: Crops do not show their label and invalid crops are rendered #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the rest of the types
… that we ignore any invalid (old) crops it has the added benefit of allowing us to find the `label` of a crop
…ocalize` controller
|
7 tasks
leekelleher
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is based on #1021 where @bjarnef discovered, that labels are not being rendered for crops. That led to a bigger investigation into why crops missed the value, which led to the discovery that we render "invalid" crops on the frontend. That means, if you change the configuration or delete a previous crop, the crop is still rendered if stored on the server. We can combine the crops from the property editor with the stored values and only extract stored sources and focal points and leave the rest.
Screenshots
Configuration
Output
