Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Use the right property editor UI alias for config options #2148

Merged

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jul 30, 2024

Fixes umbraco/Umbraco-CMS#16808

The code was a bit messy, so i refactored so the 'flow' got simpler.

Copy link

sonarcloud bot commented Jul 30, 2024

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, works as expected, LGTM! 🚀

(I added the localization for "No configuration". 👍 )

@nielslyngsoe nielslyngsoe merged commit e201800 into main Jul 30, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/use-property-editor-ui-alias-for-config-options branch July 30, 2024 13:14
@madsrasmussen madsrasmussen changed the title Use the right property editor UI alias for config options Bugfix: Use the right property editor UI alias for config options Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14: Unable to reuse existing propertyEditorSchemaAlias
4 participants