Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: focus directive refactor to support late case #2151

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

nielslyngsoe
Copy link
Member

Sometimes the umb-focus directive does not succeed in setting focus.
I dont know why after testing many scenarios and cases, everything seems fine, but it does not succeed. So to make it succeed I have refactored to it keeps trying as long as its the desired element for focus.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

  • go to the trashbin
  • then create a new document
  • see that the name input gets focus.

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe enabled auto-merge July 30, 2024 12:10
@leekelleher leekelleher self-requested a review August 5, 2024 07:39
Copy link

sonarqubecloud bot commented Aug 5, 2024

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, LGTM! 👍

@nielslyngsoe nielslyngsoe merged commit 8d6befc into main Aug 5, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/bugfix/focus-directive-late-focus branch August 5, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants