Improvement: Use constant for language workspace alias

[bjarnef]

Description

This add a constant for language workspace alias similar to other ManifestWorkspaces.
However it doesn't really seems consistent. Some are included in manifests.ts as here:
https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/4e840b9de043f8ddb03352897c5ef2a575ca8776/src/packages/documents/document-blueprints/workspace/manifests.ts#L14C14-L14C52

while other are just in a constant.ts as here:
https://github.com/umbraco/Umbraco.CMS.Backoffice/blob/4e840b9de043f8ddb03352897c5ef2a575ca8776/src/packages/user/user/workspace/constants.ts

or index.ts:

Umbraco.CMS.Backoffice/src/packages/block/block/workspace/index.ts

Line 5 in 4e840b9

export const UMB_BLOCK_WORKSPACE_ALIAS = 'Umb.Workspace.Block';

It would be great if it could be more consistency and easier to work with codebase.

Some places I noticed we have workspace under workspace/entity and entity/workspace.

I also noticed the fallback language picker seems broken at language and under user section.
It set the value, but somehow items always seems to be an empty array.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

• If my change requires a change to the documentation, I have updated the documentation in this pull request.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[madsrasmussen]

Hi @bjarnef

Thanks for the PR.

Yes, you are correct that we have inconsistencies between where we put the constants. We are currently moving all constants inside manifests and files with implementations (mostly contexts) to a constants file. This makes it possible to import the constant without loading the entire implementation.

I have updated your PR with this change.

Thanks 🥳