Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block type custom view guide #2167

Merged
merged 8 commits into from
Aug 6, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Aug 2, 2024

This PR brings:

  • Umb Manifest Icon
  • Manifest Viewer Modal.
  • Block Custom View button implemented in Block Types of Block Grid Editor Data Type Configuration.
  • View the manifest that matches the Block Type.
  • If none, then a button that can generate a manifest that will match this Block Type.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@leekelleher leekelleher self-requested a review August 6, 2024 12:00
@leekelleher leekelleher changed the base branch from main to release/14.2 August 6, 2024 15:09
…uide

# Conflicts:
#	src/packages/block/block-grid/property-editors/block-grid-areas-config/property-editor-ui-block-grid-areas-config.element.ts
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, all working as intended. 🚀

@nielslyngsoe nielslyngsoe merged commit 58cb314 into release/14.2 Aug 6, 2024
7 of 8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/block-type-custom-view-guide branch August 6, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants