Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple-app-languages-condition #2170

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Aug 5, 2024

Only shows App Language Selector when more than one app language available.

Fixes umbraco/Umbraco-CMS#16176

@nielslyngsoe
Copy link
Member Author

Hi @madsrasmussen

When you review this, then please have a look at the current data-relation between the LanguageCollectionRepository and the act of adding or removing a language. Currently that seems not to update at runtime, meaning if re-configured the user needs to refresh their browser.

Thanks :-)

Copy link

sonarcloud bot commented Aug 6, 2024

@madsrasmussen madsrasmussen self-assigned this Aug 6, 2024
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will leave the missing runtime language updates for another PR.

@nielslyngsoe nielslyngsoe merged commit 5e1222b into main Aug 6, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/only-show-app-language-selector-when-more-than-one-language branch August 6, 2024 08:20
@madsrasmussen madsrasmussen removed their assignment Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V14-RC2: Language selector shows when only 1 language
2 participants