Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Member workspace, mandatory markers #2172

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

leekelleher
Copy link
Member

Description

Provides a partial fix for umbraco/Umbraco-CMS#16079, by adding the mandatory markers for Username, Email and Passwords fields.

The validation mechanism still needs further development, but I wanted to try get the mandatory markers in for the 14.2.0-RC release.

This PR also has markup amends, for consistency across the other content workspace components.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot 2024-08-06 101147

Copy link

sonarcloud bot commented Aug 6, 2024

Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@leekelleher leekelleher merged commit 9e85ffe into main Aug 6, 2024
9 checks passed
@leekelleher leekelleher deleted the v14/bugfix/member-workspace-mandatory-fields branch August 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants