Bugfix: <umb-table> align icons centrally
#2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leekelleher
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Super, thanks @mattbrailsford! 🙏
Tested out, looking good! 🚀
leekelleher
changed the title
<umb-table> align icons centrally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR aligns the icons columns of collection views centrally to prevent miss-alignment issues when alternating between the column icon and the checkbox
Types of changes
Motivation and context
There is unnecessary movement when rolling over the table rows and switching between the checkbox and icon. This fix ensures prop alignment of both preventing this movement.
How to test?
Roll over any collection view
Screenshots (if appropriate)
Before
After
Checklist