Chore: Aligns "Picker Input Context" class names #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
requested changes
Aug 16, 2024
src/packages/members/member-group/components/input-member-group/input-member-group.context.ts
Outdated
Show resolved
Hide resolved
Adds an export alias for backwards-compatibility, with a deprecation notice.
Following the conversation: #2209 (comment) and the Picker Search feature: #2206 the `Umb{entity}PickerContext` class names will become confusing, renaming to `Umb{entity}PickerInputContext` (note "Input") should be clearer.
leekelleher
force-pushed
the
v14/chore/corrects-member-group-picker-context-export
branch
from
70fc0cf to
05310d3
Compare
leekelleher
changed the title
UmbMemberPickerContext to UmbMemberGroupPickerContext
leekelleher
changed the title
madsrasmussen
approved these changes
Aug 26, 2024
|
leekelleher
deleted the
v14/chore/corrects-member-group-picker-context-export
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated description
Following the Picker Search feature work, (PR #2206) and @madsrasmussen's feedback on this original PR, the
Umb{entity}PickerContextclass names have become confusing, so to clarify this, I've aligned theUmb{entity}PickerInputContextclass names (note, added "Input") to be clearer.With export aliases for backwards-compatibility, along with a deprecation notices.
Original description
I'd noticed that the "input-member.context.ts" and "input-member-group.context.ts" both export a type called
UmbMemberPickerContext, which seems to be a copy & paste typo in the member group one.This PR corrects the member group export and adds an alias for backwards-compatibility, along with a deprecation notice.
Types of changes