Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Readonly mode for Content Picker Property Editor UI #2229

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Feature: Readonly mode for Content Picker Property Editor UI #2229

merged 12 commits into from
Sep 2, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

This PR adds readonly mode to the Content Picker Property Editor UI

How to test

  • Add the readonly attribute to the element through developer tools

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@madsrasmussen madsrasmussen marked this pull request as ready for review August 28, 2024 11:10
@madsrasmussen madsrasmussen marked this pull request as draft August 28, 2024 11:10
@madsrasmussen madsrasmussen marked this pull request as ready for review September 1, 2024 18:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

nielslyngsoe
nielslyngsoe approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@nielslyngsoe nielslyngsoe merged commit 8493682 into main Sep 2, 2024
7 of 8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/readonly-content-picker branch September 2, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
release/14.3.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @nielslyngsoe