Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Readonly mode for Member Group Picker Property Editor UI #2238

Merged
merged 7 commits into from
Aug 31, 2024
Merged

Feature: Readonly mode for Member Group Picker Property Editor UI #2238

merged 7 commits into from
Aug 31, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

This PR adds readonly mode to the Member Group Picker Property Editor UI

How to test

  • Add the readonly attribute to the element through developer tools

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@nielslyngsoe nielslyngsoe requested review from nielslyngsoe and removed request for leekelleher August 30, 2024 19:15
nielslyngsoe
nielslyngsoe approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it works well

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nielslyngsoe nielslyngsoe merged commit 1525ed9 into main Aug 31, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v14/feature/readonly-member-group-picker-property-editor branch August 31, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
release/14.3.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @nielslyngsoe