Feature: Dynamic global extension manifest map #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… condition loads first, as order of conditions are important
…y wait until the manifest is registered so late extensions will work as well Seems to work with my hack in an entrypoint and the console logs the extension with the updated condition but its the tests I am struggling to get to work. As this code is heavily worked from me trying to Google, read RXJS docs and talking with Copilot I am not fully in confident in this approach
…red to get the ext alias that matches
… but test says otherwise compared to using it in entrypoint
…ddCondtions As the order of conditions is not important, as all conditions set on an extensions must be true/valid
Still need to uncomment & reinvestigate the late loading test
…namic-global-manifest-types # Conflicts: # src/packages/user/user/manifests.ts
|
madsrasmussen
approved these changes
Sep 13, 2024
madsrasmussen
changed the title
nielslyngsoe
deleted the
v14/feature/POC-dynamic-global-manifest-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving a manifest types union based on globally declared types, making it possible for Backoffice and even extensions to append types, without the need of declaring them in the core code.
This is prerequisite to untangle all circular dependencies of the current code.
The main changes of this PR is moving the Block Editor Custom View into its module.
The main feature lies in the few new lines appended here:
https://github.com/umbraco/Umbraco.CMS.Backoffice/pull/2249/files#diff-a9f62d958031ec501e9c71b430114cc8cf67ae233ead21a32d5b46e360bd6ddb
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist