Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: User Client Credentials #2259

Merged
merged 88 commits into from
Sep 10, 2024
Merged

Feature: User Client Credentials #2259

merged 88 commits into from
Sep 10, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Sep 9, 2024 •
edited
Loading

Description

This PR adds UI to manage User Client Credentials.

When creating a new user there are now 2 options:

  • User
  • Api User
Screenshot 2024-09-09 at 15 55 28

In a list an Api User is represented by a square avatar and a regular user is a circular avatar.
Screenshot 2024-09-09 at 15 56 07

When editing an Api User it is possible to manage client credentials:
Screenshot 2024-09-09 at 16 01 23

Screenshot 2024-09-09 at 16 01 15

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Caution

Breaking changes
UmbUserDetailModel requires kind field.
UmbUserItemModel requires kind field

@madsrasmussen
generate new server client
ac3b2ba
@madsrasmussen
add utils for user model kind
7946bfb
@madsrasmussen
add kind to user detail model
428c031
@madsrasmussen
map kind in user detail data source
4fce5b7
@madsrasmussen
select kind when creating a new user
f2beb86
@madsrasmussen
add kind as observable part on user workspace
6fa3794
@madsrasmussen
observe user kind in user condition base
84ecccb
@madsrasmussen
register allow change password condition
c0ae5e8
@madsrasmussen
add interface for client credentials server data source
5397b82
@madsrasmussen
add server client credentials data source
3e4c34d
@madsrasmussen
Create index.ts
fc2478c
@madsrasmussen
add repository alias
0765022
@madsrasmussen
return credential as an object
a96e7ee
@madsrasmussen
add repository
ba34d80
@madsrasmussen
clean up
6ee638d
@madsrasmussen
remove console log
445169d
@madsrasmussen
return newly created credential id
89f8cac
@madsrasmussen
add create modal
c35990b
@madsrasmussen
clean up
2abaf21
@madsrasmussen
Merge branch 'main' into v15/feature/user-client-credentials
738e3c5
@madsrasmussen
map kind
fe69a01
@madsrasmussen
move client credentials to the sidebar + stack the elements
d9c71b2
@madsrasmussen
Update user-allow-change-password-action.condition.ts
85f6e3f
@madsrasmussen
return data from create
5104b1c
@madsrasmussen
style add button
85bce3c
@madsrasmussen
wire up delete
c2c4ec4
@madsrasmussen
only render client credentials for api kinds
ebcd245
@madsrasmussen
set modal types
6819519
@madsrasmussen
reload when creating and deleting
10841e1
@madsrasmussen
add kind to info
5f1dbf0
@madsrasmussen madsrasmussen changed the base branch from main to v15/dev September 9, 2024 14:25
@madsrasmussen madsrasmussen marked this pull request as ready for review September 9, 2024 14:52
nielslyngsoe
nielslyngsoe approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but there is a slight issue with creating client credentials with bad characters. But this will be fixed later.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarCloud

@nielslyngsoe nielslyngsoe merged commit 47ad367 into v15/dev Sep 10, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/feature/user-client-credentials branch September 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
category/breaking release/15.0.0 type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsrasmussen @nielslyngsoe @iOvergaard