Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Blocks in RTE redirects to the frontpage #2263

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

iOvergaard
Copy link
Collaborator

Description

Adds the UmbBlockRteEntriesContext to the tinymce property editor UI so that the blocks plugin can calculate the path to the block picker modal. This is modeled after the block-list itself and is the missing piece to make the block picker work again following a regression between 14.1 and 14.2.

Fixes umbraco/Umbraco-CMS#17003

Fixes umbraco/Umbraco-CMS#16949

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test?

  1. Add an RTE to a page
  2. Add blocks to the RTE and enable the "Insert blocks" button
  3. Verify that the block picker opens when you click the button
  4. Verify that a block is inserted into the editor (click the view source button) of the rich text editor

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@iOvergaard iOvergaard marked this pull request as ready for review September 11, 2024 05:45
@iOvergaard iOvergaard merged commit f30f895 into main Sep 11, 2024
9 checks passed
@iOvergaard iOvergaard deleted the v14/bugfix/block-rte-entries-context branch September 11, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants