Build: Add advanced module check #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
added
the
internal
…(and also it forces us to use the .js extension on imports)
…mode (nodenext does not work for our modules)
|
leekelleher
approved these changes
Sep 12, 2024
iOvergaard
added
the
ignore-for-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based around this comment on X, this adds more advanced module detection so we use
import typecorrectly depending on the settings.Note: Unfortunately we cannot support "nodenext" for the "module" property, even though it would be better for "tsc" compilation. Our modules do not seem to work with that module and/or module resolution.
Note: The first suggestion with "noUncheckedIndexedAccess" would be very nice to turn on as well, but we simply have too many cases where that falls through to go through all of them. However, if someone wanted to pick that up, we would not say no.