Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tiptapExtension and tiptapToolbarExtension extension types #2300

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

leekelleher
Copy link
Member

Description

  • Introduces a new tiptapExtension extension type
  • Adds a placeholder extension for the Media Picker toolbar button/feature
  • Refactored the umb-input-tiptap and umb-tiptap-fixed-menu components to use the new extension type

Types of changes

  • New feature (non-breaking change which adds functionality)

How to test?

  • Load up a Tiptap RTE and notice that the Media Picker button is in the toolbar (and clicking it will open the media modal)

Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesmoDev JesmoDev closed this Sep 16, 2024
@JesmoDev JesmoDev reopened this Sep 16, 2024
Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesmoDev JesmoDev merged commit 580532d into v15/feature/tiptap Sep 16, 2024
3 checks passed
@JesmoDev JesmoDev deleted the v15/feature/rte/tiptap/plugins branch September 16, 2024 18:59
@iOvergaard iOvergaard changed the title Adds tiptapExtension extension type Adds tiptapExtension and tiptapToolbarExtension extension types Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants