V14: hotfix, Validation Context polish #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to call
.provide()onUmbValidationContext.But the change is not breaking as the .provide method still exists and can be called (just without any effect).
To prevent inconsistent implementation for Validation Context, compared to other Contexts.
This PR corrects the implementation, so implementing a UmbValidationContext is done in the same maner as other Contexts.
This splits UmbValidationContext into a slightly simpler implementation called UmbValidationController, this can be used in the special case where the Validation Context should be provided at a different host than the Controller Host.