Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Implement validation in 'insert field' modal #2330

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix: Implement validation in 'insert field' modal #2330

merged 2 commits into from
Sep 24, 2024

Conversation

nielslyngsoe
Copy link
Member

Implements Validation Context for the Insert Field modal, of template

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@madsrasmussen madsrasmussen changed the title Implement validation in 'insert field' modal Fix: Implement validation in 'insert field' modal Sep 24, 2024
madsrasmussen
madsrasmussen approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@nielslyngsoe nielslyngsoe merged commit d941256 into main Sep 24, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/feature/template-insert-modal-validation branch September 24, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
release/15.0.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @madsrasmussen