Fix/17179 block grid data label #2412
Closed
+54
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces refactorings to the
UmbBlockGridEntriesElement
and related context classes. The most important changes include adding new state properties to manage labels, updating methods to utilize these propertiesTypes of changes
Enhancements to Label Management:
@state
properties_resolvedCreateLabel
and_createLabel
toUmbBlockGridEntriesElement
to manage dynamic label content. (src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts
)** Introduced
#finalizeCreateLabel
method to determine the appropriate label text based on context and state. (src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts
)_resolvedCreateLabel
. (src/packages/block/block-grid/components/block-grid-entries/block-grid-entries.element.ts
)Context Class Updates:
#createLabel
state and corresponding observable inUmbBlockGridEntriesContext
. (src/packages/block/block-grid/context/block-grid-entries.context.ts
)createLabel
fromUmbBlockGridManagerContext
and updated#createLabel
inUmbBlockGridEntriesContext
. (src/packages/block/block-grid/context/block-grid-entries.context.ts
)createLabel
observable part inUmbBlockGridManagerContext
to provide label configuration. (src/packages/block/block-grid/context/block-grid-manager.context.ts
)fixes umbraco/Umbraco-CMS#17179