Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: increase z-index of element in installer layout #2413

Merged
merged 1 commit into from
Oct 7, 2024
Merged

style: increase z-index of element in installer layout #2413

merged 1 commit into from
Oct 7, 2024

Conversation

Bakersbakebread
Copy link
Contributor

@Bakersbakebread Bakersbakebread commented Oct 6, 2024 •
edited
Loading

Description

This adds a z-index: 10 to the logo so it's always on top, this behaves nicely on multiple dimensions.

Fixes:#17105

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Screenshots (if appropriate)

At raised issue dimensions:
image

1024 x 894
image

iOvergaard
iOvergaard approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit e14a538 into umbraco:main Oct 7, 2024
9 checks passed
@iOvergaard iOvergaard mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
community/pr hacktoberfest/contrib-2024 hacktoberfest-accepted release/15.1.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bakersbakebread @iOvergaard