Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Arabic translations #2414

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

IbrahimMNada
Copy link
Contributor

Description

Fixing Some Arabic words to be consistent with each other.
the translation is good in general but there are few words needed to be fixed

-mostly the one refer to Doctype and Domain

-sometimes it was referred to as 'مستند' and sometimes as 'وثيقة' . I unified them to be 'وثيقة' which represents the DocType Glossary better , same goes for Domain : 'المضيفين' and 'النطاقات' was unified to be 'النطاقات'

-the word ==>'تحرير في القماش' is wrong it means edit on fabric. so it was changed

-this word 'الأطفال' ==> means 'Kids' ==> it was changed to 'الأبناء' ==> which has more meaning and its usually used in Arabic systems in such cases.

Added some greetings which translates to :

greeting0: 'Hello! A productive start to the week with Umbraco!',
greeting1: 'Hello! A creative Tuesday with Umbraco!',
greeting2: 'Hello! A successful Wednesday managing your content!',
greeting3: 'Hello! A Thursday full of achievements with Umbraco!',
greeting4: 'Hello! It’s a great Friday for managing your website content!',
greeting5: 'Hello! Happy weekend with Umbraco!',
greeting6: 'Hello! A new Sunday, new opportunities with Umbraco!',

Types of changes

just some translations

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

better translations for out Arabian audiences

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Without knowing Arabic, I think it looks fine. I have pulled some of the texts through a translation tool and verified that the text says approximately what the description claims :-)

@iOvergaard iOvergaard merged commit 537759a into umbraco:main Oct 7, 2024
9 checks passed
@IbrahimMNada
Copy link
Contributor Author

thank you for your trust ,
can please check this although its off topic #2345

iOvergaard pushed a commit that referenced this pull request Oct 9, 2024
* tweak translations

* commit

* fix الأطفال
@iOvergaard iOvergaard added release/15.0.0-rc2 Pull requests added after rc1 and removed release/15.1.0 labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants