Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Invariant preview url #2418

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Hotfix: Invariant preview url #2418

merged 2 commits into from
Oct 9, 2024

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Oct 7, 2024 •
edited
Loading

Description

Fixes: umbraco/Umbraco-CMS#16371

Do not include 'invariant'-culture in the preview URL when the document can't vary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

nielslyngsoe
nielslyngsoe approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@nielslyngsoe nielslyngsoe merged commit 3f29b61 into release/15.0 Oct 9, 2024
9 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/hotfix/invariant-preview-url branch October 9, 2024 08:23
@nielslyngsoe nielslyngsoe mentioned this pull request Oct 9, 2024
Closed
@iOvergaard iOvergaard added the release/15.0.0-rc2 Pull requests added after rc1 label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
release/15.0.0-rc2 Pull requests added after rc1 release/15.0.0 type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsrasmussen @nielslyngsoe @iOvergaard