Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Block inline editing — create block variant #2421

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

nielslyngsoe
Copy link
Member

Adding UI to expose an inline block — fixing inline mode for Block Editors.

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

  • Create a variant block.
  • See that it is auto exposed on the current variant.
  • See that there is a button on other variants
  • Click it to see that it gets exposed on that specific variant.

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe nielslyngsoe marked this pull request as ready for review October 7, 2024 12:12
@madsrasmussen madsrasmussen self-assigned this Oct 9, 2024
@nielslyngsoe nielslyngsoe merged commit 392ed72 into release/15.0 Oct 9, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v15/hotfix/create-block-variant-inline branch October 9, 2024 08:10
@iOvergaard iOvergaard added type/bug release/15.0.0-rc2 Pull requests added after rc1 labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants