Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: TinyMCE anchor links without base URL #2462

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

leekelleher
Copy link
Member

Description

When adding/editing a link in TinyMCE that has an anchor or querystring, but no URL part, the link markup would include the current backoffice path, along with an undefined suffix.

Fixes umbraco/Umbraco-CMS#17009

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test?

Add/edit a link without entering a URL, but adding either an anchor hash or querystring value. The link's href should not contain either undefined or the current backoffice path.

@leekelleher leekelleher enabled auto-merge (squash) October 16, 2024 11:09
@leekelleher leekelleher marked this pull request as draft October 16, 2024 11:13
auto-merge was automatically disabled October 16, 2024 11:13

Pull request was converted to draft

@leekelleher leekelleher changed the base branch from main to release/15.0 October 16, 2024 11:14
it was previously prefixing the `href` with the current backoffice page URL.
@leekelleher leekelleher force-pushed the v15/bugfix/tinymce-link-anchor-qs branch from 38d3a42 to 363aaaf Compare October 16, 2024 11:16
@leekelleher leekelleher marked this pull request as ready for review October 16, 2024 11:16
@leekelleher leekelleher enabled auto-merge (squash) October 16, 2024 11:16
@iOvergaard iOvergaard added the release/15.0.0-rc2 Pull requests added after rc1 label Oct 16, 2024
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leekelleher leekelleher merged commit ab7c35d into release/15.0 Oct 16, 2024
8 checks passed
@leekelleher leekelleher deleted the v15/bugfix/tinymce-link-anchor-qs branch October 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert AnchorLink in RTE bug
2 participants