Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Tiptap Link Picker, fixes anchor with an empty URL #2522

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

leekelleher
Copy link
Member

Description

In the Tiptap Link Picker extension, when adding a link with an anchor/querystring and empty URL (for in-page navigation), the href was being stringified with the URL's null value.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How to test?

In the Tiptap editor, open the Link Picker modal, set an anchor/querystring value without setting the URL field, press Submit.
Select the link you've just created, edit in the Link Picker modal, notice that the URL value is empty and not set to a stringified null value.

it was previous appending the anchor to a  stringified `null`.
@leekelleher leekelleher merged commit 6a7e8ad into main Nov 8, 2024
8 checks passed
@leekelleher leekelleher deleted the v15/bugfix/tiptap-link-anchor-with-empty-url branch November 8, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants