Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move lit properties to UmbLitElement #832

Merged
merged 12 commits into from
Aug 11, 2023
Merged

move lit properties to UmbLitElement #832

merged 12 commits into from
Aug 11, 2023

Commits on Aug 11, 2023

  1. move lit properties to UmbLitElement 

    we cannot have lit properties on the UmbElementMixin since we are not guaranteed it's a Lit element
    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1cba2b0 View commit details
    Browse the repository at this point in the history

  2. load the initial language first from the 'lang' attribute, then from … 

    …the document, and lastly default 'en-us'
    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    972082d View commit details
    Browse the repository at this point in the history

  3. fix import order

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ffce72d View commit details
    Browse the repository at this point in the history

  4. add docs to UmbLitElement

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    313a05d View commit details
    Browse the repository at this point in the history

  5. set default dir

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2f926c1 View commit details
    Browse the repository at this point in the history

  6. optimise translation registry to only load a minimum amount of times

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2ea2846 View commit details
    Browse the repository at this point in the history

  7. remove debug info

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9ace8c1 View commit details
    Browse the repository at this point in the history

  8. add TODO

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    74e3b80 View commit details
    Browse the repository at this point in the history

  9. add proper comparator

    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    0e19883 View commit details
    Browse the repository at this point in the history

  10. make sure that registerMany registers all extensions at the same time… 

    … in order not to call next() a million times
    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8f56085 View commit details
    Browse the repository at this point in the history

  11. we call update() manualle through registerTranslation() at the moment… 

    …, so no need to observe the 'lang' attribute

this might change in the future if we separate loading of languages from changing of languages
    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6f07663 View commit details
    Browse the repository at this point in the history

  12. Revert "we call update() manualle through registerTranslation() at th… 

    …e moment, so no need to observe the 'lang' attribute"

This reverts commit 6f07663.
    @iOvergaard
    iOvergaard committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ea158b3 View commit details
    Browse the repository at this point in the history