Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context API discriminator #839

Merged
merged 33 commits into from
Sep 5, 2023
Merged

Context API discriminator #839

merged 33 commits into from
Sep 5, 2023

Conversation

nielslyngsoe
Copy link
Member

Provides a way to make a token discriminate the retrieved context.

In this way someone who needs a Document Workspace Context, can ensure that they just got that and not a Media Workspace Context.

This is needed cause Workspace Contexts are provided on the same alias, so we use a discriminator to differentiate. This is on purpose, so someone who just needs a Workspace Context to retrieve the name can be indifferent in their request.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe
ability to set discriminator method
184bfe5
@nielslyngsoe
test context discriminator
dac1b04
@nielslyngsoe
clean up
a9b3034
@nielslyngsoe
Merge remote-tracking branch 'origin/main' into feature/context-api-d…
1743448 
…iscriminator
@nielslyngsoe
Embed the discriminator method in ContextToken
d9361f3
@nielslyngsoe
main type dance, still 6 minor things to correct.
f1df5de
@nielslyngsoe
temp commit, before test removing DicriminatorType
5e682ed
@nielslyngsoe
one less generic type to parse around
7c568cd
@nielslyngsoe
implement UMB_DATA_TYPE_WORKSPACE_CONTEXT
0566c08
@nielslyngsoe
user workspace context token
2b1f130
@nielslyngsoe
stylesheet
be80bca
@nielslyngsoe
media
ce64884
@nielslyngsoe
member
b8770e4
@nielslyngsoe
document
8882d97
@nielslyngsoe
language
4ff3ddd
@nielslyngsoe
template
19b6e24
@nielslyngsoe
media-type
03b5f89
@nielslyngsoe
user group
2995880
@nielslyngsoe
dictionary
0673f08
@nielslyngsoe
member type
f377531
@nielslyngsoe
member group
e1816f6
@nielslyngsoe
correct member group token
b71b8ab
@nielslyngsoe
relation type
363eea6
@nielslyngsoe
partial views
ef136ac
@nielslyngsoe
document-type
95789d4
@nielslyngsoe
remove unused prop
cae029b
@nielslyngsoe
remove console.log
8d51012
@nielslyngsoe
docs
49c2f89
@nielslyngsoe nielslyngsoe marked this pull request as ready for review August 24, 2023 11:01
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-839.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-839.westeurope.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-839.westeurope.1.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-839.westeurope.1.azurestaticapps.net

@nathanwoulfe
Copy link
Contributor

Heya @nielslyngsoe, haven't had a chance to take this for a spin just yet, but the change make sense (even if some of the implementation detail goes over my head). Will spin it up and check that it all behaves as expected.

@nielslyngsoe nielslyngsoe requested review from madsrasmussen and removed request for iOvergaard and nathanwoulfe September 4, 2023 08:04
madsrasmussen
madsrasmussen approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@madsrasmussen madsrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-839.westeurope.1.azurestaticapps.net

@madsrasmussen madsrasmussen merged commit ef334a6 into main Sep 5, 2023
6 checks passed
@madsrasmussen madsrasmussen deleted the feature/context-api-discriminator branch September 5, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsrasmussen madsrasmussen madsrasmussen approved these changes

Assignees
No one assigned
Labels
storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielslyngsoe @nathanwoulfe @madsrasmussen