VariantContext #848
VariantContext #848
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
…xt-as-workspace-context # Conflicts: # src/packages/core/components/property-type-based-property/property-type-based-property.element.ts # src/packages/core/workspace/workspace-context/workspace-context.ts # src/packages/core/workspace/workspace-variant/workspace-variant.context.ts # src/packages/dictionary/dictionary/workspace/dictionary-workspace.context.ts # src/packages/documents/document-types/workspace/document-type-workspace.context.ts # src/packages/documents/documents/workspace/document-workspace-split-view.element.ts # src/packages/documents/documents/workspace/document-workspace.context.ts # src/packages/media/media-types/workspace/media-type-workspace.context.ts # src/packages/media/media/workspace/media-workspace.context.ts # src/packages/members/member-groups/workspace/member-group-workspace.context.ts # src/packages/members/member-types/workspace/member-type-workspace.context.ts # src/packages/members/members/workspace/member-workspace.context.ts # src/packages/settings/data-types/workspace/data-type-workspace.context.ts # src/packages/settings/languages/workspace/language/language-workspace.context.ts # src/packages/settings/relation-types/workspace/relation-type-workspace.context.ts # src/packages/templating/partial-views/workspace/partial-view-workspace.context.ts # src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts # src/packages/templating/templates/workspace/template-workspace.context.ts # src/packages/users/user-groups/workspace/user-group-workspace.context.ts # src/packages/users/users/workspace/user-workspace.context.ts
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
src/packages/core/components/property-editor-config/property-editor-config.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/components/property-editor-config/property-editor-config.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/components/variant-selector/variant-selector.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/components/variant-selector/variant-selector.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/workspace/workspace-context/workspace-invariantable-context.interface.ts
Outdated
Show resolved
Hide resolved
src/packages/core/workspace/workspace-property/workspace-property.element.ts
Outdated
Show resolved
Hide resolved
src/packages/core/workspace/workspace-split-view/workspace-split-view.context.ts
Outdated
Show resolved
Hide resolved
src/packages/settings/data-types/variant-context/data-type-variant-context.token.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mads Rasmussen <madsr@hey.com>
…//github.com/umbraco/Umbraco.CMS.Backoffice into feature/variant-context-as-workspace-context
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
2 similar comments
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
|
@madsrasmussen |
…xt-as-workspace-context # Conflicts: # src/packages/core/components/variant-selector/variant-selector.element.ts # src/packages/core/workspace/workspace-split-view/workspace-split-view.element.ts # src/packages/core/workspace/workspace-variant/variantable-property/variantable-property.element.ts # src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-848.westeurope.1.azurestaticapps.net |
nielslyngsoe
deleted the
feature/variant-context-as-workspace-context
branch
Gigant refactor to ensure property editors abilities across implementations(in other words Workspaces).
Mission:
The mission of this refactor is to lose the bond between Workspace and Property.
We have too many specific requirements for Workspaces, which do not apply across the application.
Some workspace has variants, which means different names and property values depending on the variantId.
This will still be the case, but to make the code of property editors simpler, I'm introducing a Dataset Context.
A dataset is a set of properties. for the datatype configuration there is one.. for documents there is one pr. variant.
A dataset will hold a name, properties, variantId, and eventually some publishing/save states.
overall this means the code of a property editor does not need to care about variants when requesting the name or values of other properties.
Also counting for those concerned about saving/publishing state. Those will though have to request with a different Context Token to get such datasetContext.
Notice
with this change workspace-property element does not take a value property. It retrieves it via the variant context. This means that now the variant context is required to have Property Editor UIs working. — But this is sort of on purpose as well. In this way, we have ensured property editors using the variant will work in any scenario.