Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/Stylesheets #850

Merged
merged 70 commits into from
Sep 6, 2023
Merged

Feature/Stylesheets #850

merged 70 commits into from
Sep 6, 2023

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Aug 30, 2023

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

julczka and others added 30 commits July 31, 2023 10:02
@julczka
correct the type
462f68e
@julczka
return the entity type from partial views
019923d
@julczka
remove console.log
ef46b4a
@julczka
add missing context methods
e073802
@julczka
add folder data source
e5388db
@julczka
Update stylesheet-workspace.context.ts
c15b666
@julczka
implement crud source details methods
4ff4d67
@julczka
add docs and rules endpoints
6d200e3
@julczka
implement repository interfaceces
5e26f2b
@julczka
implement folder methods
38e405f
@julczka
implement stylesheet rules methods in repository
3f7e7d9
@julczka
Update stylesheet-workspace.context.ts
61b565f
@julczka
add some handlers
8dd430f
@julczka
Merge branch 'main' into feature/setup-stylesheet-workspace
c6e4db9
@julczka
add views
d94667f
@julczka
add path and name and save action
be032ef
@julczka
add code editor
deb1687
@julczka
Merge branch 'main' into feature/setup-stylesheet-workspace
7ac0bd7
@julczka
commit
6c4b03d
@nielslyngsoe
use alias reference from workspace manifest
7f2f58d
@nielslyngsoe
correct workspace alias
c4dfeaa
@nielslyngsoe
use context token
62225a9
@nielslyngsoe
remove to editor
fcf00f9
@nielslyngsoe
fix import
7b79522
@nielslyngsoe
type casting fix
82e24d5
@julczka
fix ts error
02631c6
@julczka
Merge branch 'main' into feature/setup-stylesheet-workspace
a5756c4
@julczka
the other workspace wip
3ddd4dc
@julczka
add modal
5b7409a
@julczka
create form with preview
2aafa18
@nielslyngsoe
Copy link
Member

I get some issues when running this locally with Mocked data.

image

There are a few end-points that do not respond.

I also get this issue from Vite when running the dev server:

image

Would you be able to have a look at that, thanks :-)

julczka and others added 6 commits September 4, 2023 12:16
@julczka
Merge branch 'main' into feature/setup-stylesheet-workspace
0c13091
@julczka
add handlers
71fca5e
@julczka
fix handlers
5e6efa7
@julczka
add diconnected callback
58e6872
@nielslyngsoe
Merge remote-tracking branch 'origin/main' into feature/setup-stylesh…
e09a425 
…eet-workspace

# Conflicts:
#	src/packages/templating/partial-views/workspace/partial-view-workspace.context.ts
#	src/packages/templating/stylesheets/workspace/stylesheet-workspace.context.ts
@julczka
remove vite inline import
075f197
@nielslyngsoe
Copy link
Member

It's like the router of the Stylesheet workspace is not connected properly, cause when switching around I stay on the same tab. though Url does not specify it anymore?

Also switching around after a switch between the two seems broken?

Also when saving I get an error. BTW. I'm testing on mocked data.

I'm also feeling like missing something on the RTE DataType, but maybe that's another feature?
image

@julczka
Copy link
Contributor Author

julczka commented Sep 6, 2023

It's like the router of the Stylesheet workspace is not connected properly, cause when switching around I stay on the same tab. though Url does not specify it anymore?

It is a bug in the workspace tabs - url does not change in the tabs when you switch to a different item from the tree. I was told to leave that

nielslyngsoe
nielslyngsoe approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'm happy to get it in now :-)

@nielslyngsoe nielslyngsoe merged commit d1fdb88 into main Sep 6, 2023
6 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/setup-stylesheet-workspace branch September 6, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julczka @nielslyngsoe