rename to propertyEditor not data-type #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-ui-config-collection
madsrasmussen
approved these changes
Sep 7, 2023
…or-ui-config-collection # Conflicts: # src/packages/core/workspace/workspace-property/workspace-property.context.ts
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-860.westeurope.1.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-860.westeurope.1.azurestaticapps.net |
nielslyngsoe
deleted the
feature/property-editor-ui-config-collection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename DataTypeConfigCollection to PropertyEditorConfigCollection and move it into property editors.
Motivation:
Since we use Property Editor UIs for more than just Property Editors via Data-Type. it feels weird to take a DataTypeConfigCollection.
Especially because it does not need to have touched a Data-type before: For example for Data-type configuration we use Property Editor UIs, which is being configured via the Manifest.