Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dictionary update #890

Merged
merged 18 commits into from
Oct 5, 2023
Merged

Feature/dictionary update #890

merged 18 commits into from
Oct 5, 2023

Conversation

loivsen
Copy link
Contributor

@loivsen loivsen commented Sep 20, 2023

Dictionary

  • Localizations
  • Route URL for creating a new dictionary item create/parentId. The id may be null if no parent.
  • Mock data were lacking a put API call and showed error. Added put for mocking.

iOvergaard
iOvergaard requested changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspace part looks good, but a few optimizations here and there. Please also make sure it is tested against the real CMS.

src/mocks/handlers/dictionary.handlers.ts Outdated Show resolved Hide resolved
src/packages/dictionary/dashboards/dictionary/dashboard-localization-dictionary.element.ts Outdated Show resolved Hide resolved
src/packages/dictionary/dictionary/workspace/dictionary-workspace-editor.element.ts Outdated Show resolved Hide resolved
...ges/dictionary/dictionary/workspace/views/editor/workspace-view-dictionary-editor.element.ts Show resolved Hide resolved
@iOvergaard iOvergaard merged commit b669f31 into main Oct 5, 2023
6 checks passed
@iOvergaard iOvergaard deleted the feature/dictionary-update branch October 5, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loivsen @iOvergaard