Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: move event files into core package #891

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Improvement: move event files into core package #891

merged 6 commits into from
Oct 9, 2023

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Sep 20, 2023 •
edited
Loading

In the pursuit of getting rid of the shared folder, I have moved the event files into the core folder.

Merge together with: umbraco/Umbraco-CMS#14844

@madsrasmussen madsrasmussen marked this pull request as draft September 20, 2023 14:07
@madsrasmussen madsrasmussen changed the title Improvement: move event files from shared into core Improvement: move event files into core package Sep 20, 2023
@madsrasmussen madsrasmussen mentioned this pull request Sep 21, 2023
Merged
@madsrasmussen madsrasmussen marked this pull request as ready for review September 21, 2023 08:28
@iOvergaard
Copy link
Collaborator

@madsrasmussen it seems some conflicts have been detected, would you look into them, please?

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-891.westeurope.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-891.westeurope.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-stone-0033b3603-891.westeurope.1.azurestaticapps.net

@madsrasmussen
Copy link
Contributor Author

@iOvergaard This PR is up to date now. Can you do a new review?

@iOvergaard iOvergaard merged commit becc01f into main Oct 9, 2023
6 checks passed
@iOvergaard iOvergaard deleted the improvement/move-event-files branch October 9, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
storybook
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @iOvergaard