Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stacking of popovers #894

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

maudsj
Copy link
Contributor

@maudsj maudsj commented Sep 21, 2023

Dropdowns, color picker etc displaying under the following property editors, resulting in e.g. elements of a dropdown not being selectable anymore

Remove container type styling on host in workspace property layout and remove z-index on headerColumn (labels)

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Add an extra language in settings, use color picker in content

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nielslyngsoe
Copy link
Member

nielslyngsoe commented Oct 5, 2023

Hi @maudsj

Seems to work, but this change breaks the container query — Maybe this is our only option, with the current state of Container Queries. But I would really like us to investigate if there could be another option

How do you see our options?

If nothing else can work for us, we should get rid of the Container Query and then implement another way for this to break into the look of the layout with the label on top and the editor below.

@nielslyngsoe nielslyngsoe self-requested a review October 5, 2023 18:43
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some further investigation. It seems that this is the go-to solution for now, and then we can return to our options for responsiveness later.
So I approve and merge this :-)

@nielslyngsoe nielslyngsoe merged commit d61a1e3 into umbraco:main Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants