-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable api js and element js for the same extension #919
Enable api js and element js for the same extension #919
Conversation
…on-for-element-and-api-js # Conflicts: # src/packages/users/users/modals/user-picker/user-picker-modal.element.ts # src/packages/users/users/workspace/user-workspace-editor.element.ts
…on-for-element-and-api-js
…on-for-element-and-api-js # Conflicts: # src/packages/core/collection/collection-selection-actions.element.ts # src/packages/core/workspace/workspace-action/workspace-action.element.ts
…on-for-element-and-api-js
…on-for-element-and-api-js # Conflicts: # src/packages/user/user/collection/views/table/user-collection-table-view.element.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, everything looks good to me. I have left two smaller comments.
Do we have some documentation we need to update with these changes?
Update:
We will update docs for the next preview release, so we don't have documentation now that doesn't work for the current preview release.
Enable an Extension to both bring a Element and an API.
Change log:
element
export for elements and ´api´ export for APIs.