Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate RxJS #970

Merged
merged 20 commits into from
Nov 9, 2023
Merged

Isolate RxJS #970

merged 20 commits into from
Nov 9, 2023

Conversation

nielslyngsoe
Copy link
Member

Isolate RxJS inside our State Objects to avoid confusion or unforeseen manipulation of the data.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

iOvergaard
iOvergaard requested changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works with one small change, but I don't know if my suggestion is too simplistic:

src/shared/auth/auth.context.ts Show resolved Hide resolved
@nielslyngsoe nielslyngsoe merged commit 03cd3c3 into main Nov 9, 2023
6 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/isolate-rxjs branch November 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

@madsrasmussen madsrasmussen Awaiting requested review from madsrasmussen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @iOvergaard