Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: Split Current User from auth #979

Merged
merged 48 commits into from
Nov 13, 2023
Merged

Improvement: Split Current User from auth #979

merged 48 commits into from
Nov 13, 2023

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Nov 9, 2023 •
edited
Loading

This PR separates the Auth Context into an AuthContext - responsible for user authentication. And a CurrentUserContext - responsible for retrieving and interacting with data for the Authenticated User.

The PR also does the first round of cleanup in the App Element, to further split responsibility into smaller areas:

UmbSeverConnection: Check the current Run Time Level - Install, Upgrade, etc of the server.
UmbDebugContextController: Listen for Context Debug events.

There is still some code in the app.element.ts that should be moved around, but it will be part of another clean-up round.

With these changes, we also fixed a bug where the current user didn't get loaded correctly with mocked data.

What to test:

  • The current user gets loaded with mocked data
  • The current user gets loaded with data from the CMS

@madsrasmussen
add current user context
e8ba2c7
@madsrasmussen
move current user methods from auth context into current user context
4df0c68
@madsrasmussen
clean up interface
a13b8da
@madsrasmussen
provide current user context from entry point
5484dce
@madsrasmussen
observe when user is logged in and fetch the current user
77cd37c
@madsrasmussen
move entry point manifest to bundle
dee6714
@madsrasmussen
make auth context self providing
60c328c
@madsrasmussen
make app context self providing
3f95a96
@madsrasmussen
clean up
54b2547
@madsrasmussen
rename logged in user to current user
bf52ef7
@madsrasmussen
delete type from auth
5017bdd
@madsrasmussen
remove unused
229e79e
@madsrasmussen
update code to get the current user from new context
5082bdc
@madsrasmussen
Merge branch 'main' into feature-split-auth-and-user
19b13a7
@madsrasmussen
consume current user context instead of auth context
1cb4aee
@madsrasmussen
use current user context
5777bd4
@madsrasmussen
more imports of correct context
741e5c3
@madsrasmussen
use current user context
e0b90c2
@madsrasmussen
add interface to file name to remove confusion
df4970e
@madsrasmussen
temp solution to make ts happy
1b55821
@madsrasmussen
move language watcher into current user context
a22ebf1
@madsrasmussen
remove dependency on current user
0e987be
@madsrasmussen
this.lang is never set
1b7ba6c
@madsrasmussen
remove import
8b49bef
@madsrasmussen
make auth context now if auth is bypassed
e1746cf
@madsrasmussen
move isLoggedIn logic to auth context
189bdc5
@madsrasmussen
align naming
dad6a6e
@madsrasmussen
make conditional easier to read
a10ae34
@madsrasmussen
remove temp method
52ecf77
@madsrasmussen
rename runtime level to server status
d805318
@madsrasmussen madsrasmussen marked this pull request as ready for review November 13, 2023 10:45
nielslyngsoe
nielslyngsoe approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restructure looks good, I did make a few comments, But I assume you will look at those before merging :-)

@madsrasmussen madsrasmussen merged commit 34509c5 into main Nov 13, 2023
6 checks passed
@madsrasmussen madsrasmussen deleted the feature-split-auth-and-user branch November 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielslyngsoe nielslyngsoe nielslyngsoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsrasmussen @nielslyngsoe