Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal auto-paring does not support rerun library for wgs_tumor_normal #678

Open
victorskl opened this issue May 25, 2024 · 3 comments
Open

Comments

@victorskl
Copy link
Member

victorskl commented May 25, 2024

Context:

At the mo, automation auto-pairing skip if tumor and/or normal library id contains rerun marker.

# FIXME - skip if normal library id contains rerun

# FIXME - skip if tumor library id contains rerun

Affected:

Run the following Athena SQL query to determine all affected samples.

select 
    "id",
    "library_id",
    "phenotype",
    "sample_id", 
    "subject_id", 
    "external_subject_id", 
    "external_sample_id",
    "project_name",
    "project_owner"
from "data_portal_labmetadata" 
where 
    "phenotype" in ('tumor', 'normal') and 
    "type" in ('WGS') and 
    "workflow" in ('clinical', 'research') and 
    "library_id" like '%_rerun';

There are about 23 libraries from 2020-2021.

Consider:

Consider support the case in pairing logic.
Alternatively, if rerun are to be always take precedent, consider fixing at Lab metadata.

Workaround:

Need to trigger TN job manually

@victorskl
Copy link
Member Author

@victorskl
Copy link
Member Author

victorskl commented May 25, 2024

Meanwhile, this may attempt Option 1 with "manual pairing only" as documented in [1].

REF:

  1. https://github.com/umccr/data-portal-apis/blob/dev/docs/pipeline/automation/tumor_normal.md

@ohofmann
Copy link
Member

In turns of logic - I'd always pick a _rerun over the original. Mid-term we need a deprecated flag for libraries that been been superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants