This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
AttributedTypeResolver - Adds locks to prevent concurrency issue #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second attempt to fix #238
leekelleher
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt to fix #238
I originally thought that using a
ConcurrentDictionarywould mitigate from the concurrency issue, as outlined in issue #238. But that doesn't appear to be the case. I'm not sure why we'd want to use aConcurrentDictionaryif it's not working as expected - which, is most likely due to my understanding of how it actually works. This patch changes from usingConcurrentDictionaryto a regular genericDictionary, adding locks to prevent concurrently issues between reads/writes.