This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
Update type converters to treat emtpy string the same as null #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty strings pass through to the base TypeConverter and for enumerable types at least, this results in a NotSupportedException. cc90af9 added support for accepting null values, and in pretty much every case, empty string should be treated as null: no meaninful data can be gleaned from it for conversion. EnumConverter works without the check because the empty string gets pased to the base ConvertFrom method which just returns the default enum value. But we might as well be explicit about the expected return result for empty strings. Fixes #58
|
Merging this into my current branch will cause trouble if done automatically as I've deleted the ConverterHelper class in favour of a base TypeConverter. I'll merge things manually then close this. Thanks for the code! 👍 |
JimBobSquarePants
added a commit
that referenced
this pull request
Apr 7, 2015
|
Cool. Glad to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty strings pass through to the base TypeConverter and for enumerable
types at least, this results in a NotSupportedException.
cc90af9 added support for accepting null values, and in pretty much
every case, empty string should be treated as null: no meaninful data
can be gleaned from it for conversion.
EnumConverter works without the check because the empty string gets
pased to the base ConvertFrom method which just returns the default enum
value. But we might as well be explicit about the expected return result
for empty strings.
Fixes #58